diff options
| author | OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> | 2009-08-06 15:07:39 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-08-07 10:39:56 -0700 |
| commit | 2d8dd38a5aa0cc2490bbad9b75e77fa154e1d145 (patch) | |
| tree | dcc1ec93e95dde5704a7e37939454c9b24904758 /fs/namespace.c | |
| parent | 69130c7cf96ea853dc5be599dd6a4b98907d39cc (diff) | |
| download | op-kernel-dev-2d8dd38a5aa0cc2490bbad9b75e77fa154e1d145.zip op-kernel-dev-2d8dd38a5aa0cc2490bbad9b75e77fa154e1d145.tar.gz | |
vfs: mnt_want_write_file(): fix special file handling
I suspect that mnt_want_write_file() may have wrong assumption. I think
mnt_want_write_file() is assuming it increments ->mnt_writers if
(file->f_mode & FMODE_WRITE). But, if it's special_file(), it is false?
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Acked-by: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/namespace.c')
| -rw-r--r-- | fs/namespace.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/namespace.c b/fs/namespace.c index 277c28a..7230787 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -316,7 +316,8 @@ EXPORT_SYMBOL_GPL(mnt_clone_write); */ int mnt_want_write_file(struct file *file) { - if (!(file->f_mode & FMODE_WRITE)) + struct inode *inode = file->f_dentry->d_inode; + if (!(file->f_mode & FMODE_WRITE) || special_file(inode->i_mode)) return mnt_want_write(file->f_path.mnt); else return mnt_clone_write(file->f_path.mnt); |
