summaryrefslogtreecommitdiffstats
path: root/fs/gfs2
diff options
context:
space:
mode:
authorEryu Guan <guaneryu@gmail.com>2016-08-02 19:58:28 +0800
committerLinus Torvalds <torvalds@linux-foundation.org>2016-08-07 10:03:31 -0400
commit337684a1746f93ae107e05d90977b070bb7e39d8 (patch)
tree1922204c16c1b9a8a54cecb8d3512f2b46a2695b /fs/gfs2
parentfe64f3283fb315e3d8f2b78785a86904a852ca82 (diff)
downloadop-kernel-dev-337684a1746f93ae107e05d90977b070bb7e39d8.zip
op-kernel-dev-337684a1746f93ae107e05d90977b070bb7e39d8.tar.gz
fs: return EPERM on immutable inode
In most cases, EPERM is returned on immutable inode, and there're only a few places returning EACCES. I noticed this when running LTP on overlayfs, setxattr03 failed due to unexpected EACCES on immutable inode. So converting all EACCES to EPERM on immutable inode. Acked-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/gfs2')
-rw-r--r--fs/gfs2/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index e0621ca..e4da0ec 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -1800,7 +1800,7 @@ int gfs2_permission(struct inode *inode, int mask)
}
if ((mask & MAY_WRITE) && IS_IMMUTABLE(inode))
- error = -EACCES;
+ error = -EPERM;
else
error = generic_permission(inode, mask);
if (gfs2_holder_initialized(&i_gh))
OpenPOWER on IntegriCloud