summaryrefslogtreecommitdiffstats
path: root/fs/gfs2
diff options
context:
space:
mode:
authorSteven Whitehouse <swhiteho@redhat.com>2013-12-04 11:14:05 +0000
committerSteven Whitehouse <swhiteho@redhat.com>2014-01-03 09:59:30 +0000
commit7de41d36ff5885141a16c74a044936cf878c770f (patch)
treee0cdc52693444078ba899f3d8cba3626f351512c /fs/gfs2
parent7aed98fb1dfbd3f6d7b78647ff2956de2fcc4150 (diff)
downloadop-kernel-dev-7de41d36ff5885141a16c74a044936cf878c770f.zip
op-kernel-dev-7de41d36ff5885141a16c74a044936cf878c770f.tar.gz
GFS2: Remove test which is always true
Since gfs2_inplace_reserve() is always called with a valid alloc parms structure, there is no need to test for this within the function itself - and in any case, after we've all ready dereferenced it anyway. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2')
-rw-r--r--fs/gfs2/rgrp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
index 797f1d3..2584710 100644
--- a/fs/gfs2/rgrp.c
+++ b/fs/gfs2/rgrp.c
@@ -1943,7 +1943,7 @@ int gfs2_inplace_reserve(struct gfs2_inode *ip, const struct gfs2_alloc_parms *a
/* Skip unuseable resource groups */
if ((rs->rs_rbm.rgd->rd_flags & (GFS2_RGF_NOALLOC |
GFS2_RDF_ERROR)) ||
- (ap && (ap->target > rs->rs_rbm.rgd->rd_extfail_pt)))
+ (ap->target > rs->rs_rbm.rgd->rd_extfail_pt))
goto skip_rgrp;
if (sdp->sd_args.ar_rgrplvb)
OpenPOWER on IntegriCloud