diff options
| author | Cyrill Gorcunov <gorcunov@gmail.com> | 2008-03-03 21:54:21 +0300 |
|---|---|---|
| committer | Steven Whitehouse <swhiteho@redhat.com> | 2008-03-31 10:41:28 +0100 |
| commit | 182fe5abd8ebbb3a00c1be91f44e4783e139918c (patch) | |
| tree | 7404993656166f2b7cb78e54e4275d44336ba27c /fs/gfs2/quota.c | |
| parent | 105284970ba7d0d0ff4b97e57728eac7adf6a42a (diff) | |
| download | op-kernel-dev-182fe5abd8ebbb3a00c1be91f44e4783e139918c.zip op-kernel-dev-182fe5abd8ebbb3a00c1be91f44e4783e139918c.tar.gz | |
[GFS2] possible null pointer dereference fixup
gfs2_alloc_get may fail so we have to check it to prevent
NULL pointer dereference.
Signed-off-by: Cyrill Gorcunov <gorcunov@gamil.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/gfs2/quota.c')
| -rw-r--r-- | fs/gfs2/quota.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c index a08dabd..636bccf 100644 --- a/fs/gfs2/quota.c +++ b/fs/gfs2/quota.c @@ -617,8 +617,9 @@ static int gfs2_adjust_quota(struct gfs2_inode *ip, loff_t loc, int err = -EIO; if (gfs2_is_stuffed(ip)) { - struct gfs2_alloc *al = NULL; - al = gfs2_alloc_get(ip); + struct gfs2_alloc *al = gfs2_alloc_get(ip); + if (!al) + return -ENOMEM; /* just request 1 blk */ al->al_requested = 1; gfs2_inplace_reserve(ip); @@ -729,6 +730,10 @@ static int do_sync(unsigned int num_qd, struct gfs2_quota_data **qda) if (nalloc) { al = gfs2_alloc_get(ip); + if (!al) { + error = -ENOMEM; + goto out_gunlock; + } al->al_requested = nalloc * (data_blocks + ind_blocks); |
