diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-11-29 22:08:00 +0100 |
|---|---|---|
| committer | Miklos Szeredi <mszeredi@suse.cz> | 2011-12-13 11:58:49 +0100 |
| commit | c411cc88d873b3f68635a04691f7f115c46bc39e (patch) | |
| tree | 388469bbd475b0411bbf4868c2fe8f3c803737fe /fs/fuse | |
| parent | c07c3d193412bbf4e9f405e75dc84e35e77fac28 (diff) | |
| download | op-kernel-dev-c411cc88d873b3f68635a04691f7f115c46bc39e.zip op-kernel-dev-c411cc88d873b3f68635a04691f7f115c46bc39e.tar.gz | |
fuse: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Diffstat (limited to 'fs/fuse')
| -rw-r--r-- | fs/fuse/file.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/fuse/file.c b/fs/fuse/file.c index e0b60ac..c297425 100644 --- a/fs/fuse/file.c +++ b/fs/fuse/file.c @@ -1776,7 +1776,7 @@ long fuse_do_ioctl(struct file *file, unsigned int cmd, unsigned long arg, BUILD_BUG_ON(sizeof(struct fuse_ioctl_iovec) * FUSE_IOCTL_MAX_IOV > PAGE_SIZE); err = -ENOMEM; - pages = kzalloc(sizeof(pages[0]) * FUSE_MAX_PAGES_PER_REQ, GFP_KERNEL); + pages = kcalloc(FUSE_MAX_PAGES_PER_REQ, sizeof(pages[0]), GFP_KERNEL); iov_page = (struct iovec *) __get_free_page(GFP_KERNEL); if (!pages || !iov_page) goto out; |
