summaryrefslogtreecommitdiffstats
path: root/fs/fscache/proc.c
diff options
context:
space:
mode:
authorJiaying Zhang <jiayingz@google.com>2011-08-19 19:13:32 -0400
committerTheodore Ts'o <tytso@mit.edu>2011-08-19 19:13:32 -0400
commitdccaf33fa37a1bc5d651baeb3bfeb6becb86597b (patch)
treeff41c9c0208589fded8176089380e316dd5c7965 /fs/fscache/proc.c
parent9dd75f1f1a02d656a11a7b9b9e6c2759b9c1e946 (diff)
downloadop-kernel-dev-dccaf33fa37a1bc5d651baeb3bfeb6becb86597b.zip
op-kernel-dev-dccaf33fa37a1bc5d651baeb3bfeb6becb86597b.tar.gz
ext4: flush any pending end_io requests before DIO reads w/dioread_nolock
There is a race between ext4 buffer write and direct_IO read with dioread_nolock mount option enabled. The problem is that we clear PageWriteback flag during end_io time but will do uninitialized-to-initialized extent conversion later with dioread_nolock. If an O_direct read request comes in during this period, ext4 will return zero instead of the recently written data. This patch checks whether there are any pending uninitialized-to-initialized extent conversion requests before doing O_direct read to close the race. Note that this is just a bandaid fix. The fundamental issue is that we clear PageWriteback flag before we really complete an IO, which is problem-prone. To fix the fundamental issue, we may need to implement an extent tree cache that we can use to look up pending to-be-converted extents. Signed-off-by: Jiaying Zhang <jiayingz@google.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: stable@kernel.org
Diffstat (limited to 'fs/fscache/proc.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud