summaryrefslogtreecommitdiffstats
path: root/fs/file.c
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2012-11-12 01:19:02 -0500
committerAl Viro <viro@zeniv.linux.org.uk>2012-11-12 01:19:02 -0500
commit5a8477660d9ddc090203736d7271137265cb25bb (patch)
tree693128e654759348bf6393eca128acc661aff9da /fs/file.c
parenta736427fa1103158338839813139b20763c7b13e (diff)
downloadop-kernel-dev-5a8477660d9ddc090203736d7271137265cb25bb.zip
op-kernel-dev-5a8477660d9ddc090203736d7271137265cb25bb.tar.gz
kill bogus BUG_ON() in do_close_on_exec()
It can be legitimately triggered via procfs access. Now, at least 2 of 3 of get_files_struct() callers in procfs are useless, but when and if we get rid of those we can always add WARN_ON() here. BUG_ON() at that spot is simply wrong. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/file.c')
-rw-r--r--fs/file.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/file.c b/fs/file.c
index d3b5fa8..331e7d2 100644
--- a/fs/file.c
+++ b/fs/file.c
@@ -685,7 +685,6 @@ void do_close_on_exec(struct files_struct *files)
struct fdtable *fdt;
/* exec unshares first */
- BUG_ON(atomic_read(&files->count) != 1);
spin_lock(&files->file_lock);
for (i = 0; ; i++) {
unsigned long set;
OpenPOWER on IntegriCloud