diff options
| author | OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> | 2007-07-15 23:39:56 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-07-16 09:05:42 -0700 |
| commit | 9aacd599342fdfc1fb9422f37e900609b7a46249 (patch) | |
| tree | 45c835330122496dfd51b946890ce8580d854173 /fs/fat/inode.c | |
| parent | 259902ea951008bcbd31a49f667062ff8012ef55 (diff) | |
| download | op-kernel-dev-9aacd599342fdfc1fb9422f37e900609b7a46249.zip op-kernel-dev-9aacd599342fdfc1fb9422f37e900609b7a46249.tar.gz | |
fat: gcc 4.3 warning fix
This patch fixes the following warnings.
fs/fat/dir.c: In function 'fat_parse_long':
include/linux/msdos_fs.h:294: warning: array subscript is above array bounds
include/linux/msdos_fs.h:295: warning: array subscript is above array bounds
include/linux/msdos_fs.h:295: warning: array subscript is above array bounds
The ->name is defined as "name[8], ext[3]", but fat_checksum() uses
those as name[11]. There is no actual problem, but it's not a good manner.
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/fat/inode.c')
| -rw-r--r-- | fs/fat/inode.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c index 479722d..cfaf587 100644 --- a/fs/fat/inode.c +++ b/fs/fat/inode.c @@ -354,8 +354,7 @@ static int fat_fill_inode(struct inode *inode, struct msdos_dir_entry *de) } else { /* not a directory */ inode->i_generation |= 1; inode->i_mode = MSDOS_MKMODE(de->attr, - ((sbi->options.showexec && - !is_exec(de->ext)) + ((sbi->options.showexec && !is_exec(de->name + 8)) ? S_IRUGO|S_IWUGO : S_IRWXUGO) & ~sbi->options.fs_fmask) | S_IFREG; MSDOS_I(inode)->i_start = le16_to_cpu(de->start); |
