summaryrefslogtreecommitdiffstats
path: root/fs/fat/inode.c
diff options
context:
space:
mode:
authorOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>2009-09-20 01:31:58 +0900
committerOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>2009-09-20 01:35:25 +0900
commited248b290da7297c9b9a3ff180f5eee4db016224 (patch)
tree86793695dccd8ff8e6973f546da0020964717534 /fs/fat/inode.c
parent955234755ce4a2c33cfc558912aa8f2148cc1fc6 (diff)
downloadop-kernel-dev-ed248b290da7297c9b9a3ff180f5eee4db016224.zip
op-kernel-dev-ed248b290da7297c9b9a3ff180f5eee4db016224.tar.gz
fat: Check s_dirt in fat_sync_fs()
If we didn't check sb->s_dirt, it will update the FSINFO unconditionally. It will reduce the filetime of flash base device. So, this checks sb->s_dirt. sb->s_dirt is racy, however FSINFO is just hint. So even if there is race, and we hit it, it would not become big problem. And this also is as workaround of suspend problem. Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Diffstat (limited to 'fs/fat/inode.c')
-rw-r--r--fs/fat/inode.c14
1 files changed, 9 insertions, 5 deletions
diff --git a/fs/fat/inode.c b/fs/fat/inode.c
index 63a5c1a..a8a3afe 100644
--- a/fs/fat/inode.c
+++ b/fs/fat/inode.c
@@ -451,12 +451,16 @@ static void fat_write_super(struct super_block *sb)
static int fat_sync_fs(struct super_block *sb, int wait)
{
- lock_super(sb);
- fat_clusters_flush(sb);
- sb->s_dirt = 0;
- unlock_super(sb);
+ int err = 0;
- return 0;
+ if (sb->s_dirt) {
+ lock_super(sb);
+ sb->s_dirt = 0;
+ err = fat_clusters_flush(sb);
+ unlock_super(sb);
+ }
+
+ return err;
}
static void fat_put_super(struct super_block *sb)
OpenPOWER on IntegriCloud