summaryrefslogtreecommitdiffstats
path: root/fs/f2fs
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk.kim@samsung.com>2012-12-12 09:47:39 +0900
committerJaegeuk Kim <jaegeuk.kim@samsung.com>2012-12-26 10:39:51 +0900
commitdfb7c0ceab57fee7618f4c9c31c5a89254e8530a (patch)
tree562e1bd2ee29b43b1b1c2bd0f5ce30f3c09064d9 /fs/f2fs
parent637704cbc95c02d18741b4a6e7a5d2397f8b28ce (diff)
downloadop-kernel-dev-dfb7c0ceab57fee7618f4c9c31c5a89254e8530a.zip
op-kernel-dev-dfb7c0ceab57fee7618f4c9c31c5a89254e8530a.tar.gz
f2fs: remove set_page_dirty for atomic f2fs_end_io_write
We should guarantee not to do *scheduling while atomic*. I found, in atomic f2fs_end_io_write(), there is a set_page_dirty() call to deal with IO errors. But, set_page_dirty() calls: -> f2fs_set_data_page_dirty() -> set_dirty_dir_page() -> cond_resched() which results in scheduling. In order to avoid this, I'd like to remove simply set_page_dirty(), since the page is already marked as ERROR and f2fs will be operated as the read-only mode as well. So, there is no recovery issue with this. Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Diffstat (limited to 'fs/f2fs')
-rw-r--r--fs/f2fs/segment.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 1b26e4e..8bc1b6f 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -631,7 +631,6 @@ static void f2fs_end_io_write(struct bio *bio, int err)
if (page->mapping)
set_bit(AS_EIO, &page->mapping->flags);
set_ckpt_flags(p->sbi->ckpt, CP_ERROR_FLAG);
- set_page_dirty(page);
}
end_page_writeback(page);
dec_page_count(p->sbi, F2FS_WRITEBACK);
OpenPOWER on IntegriCloud