summaryrefslogtreecommitdiffstats
path: root/fs/f2fs
diff options
context:
space:
mode:
authorJaegeuk Kim <jaegeuk@kernel.org>2014-09-08 10:59:43 -0700
committerJaegeuk Kim <jaegeuk@kernel.org>2014-09-09 14:46:36 -0700
commit0b4c5afde9b57c08b55d26725d228d5314cfc57a (patch)
treef034d99b62dd117b135c82061cf1f64d2d0b68ae /fs/f2fs
parent9a01b56b1a79e210e9d2d67c9b18906d31d536c4 (diff)
downloadop-kernel-dev-0b4c5afde9b57c08b55d26725d228d5314cfc57a.zip
op-kernel-dev-0b4c5afde9b57c08b55d26725d228d5314cfc57a.tar.gz
f2fs: fix negative value for lseek offset
If application throws negative value of lseek with SEEK_DATA|SEEK_HOLE, previous f2fs went into BUG_ON in get_dnode_of_data, which was reported by Tommi Rantala. He could make a simple code to detect this having: lseek(fd, -17595150933902LL, SEEK_DATA); This patch should resolve that bug. Reported-by: Tommi Rentala <tt.rantala@gmail.com> [Jaegeuk Kim: relocate the condition as suggested by Chao] Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs')
-rw-r--r--fs/f2fs/file.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 9f0ea3d..5cde363 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -353,6 +353,8 @@ static loff_t f2fs_llseek(struct file *file, loff_t offset, int whence)
maxbytes, i_size_read(inode));
case SEEK_DATA:
case SEEK_HOLE:
+ if (offset < 0)
+ return -ENXIO;
return f2fs_seek_block(file, offset, whence);
}
OpenPOWER on IntegriCloud