diff options
| author | Jaegeuk Kim <jaegeuk@kernel.org> | 2017-03-21 10:59:50 -0400 |
|---|---|---|
| committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2017-03-29 17:34:40 -0700 |
| commit | c13ff37e359bb3eacf4e1760dcea8d9760aa7459 (patch) | |
| tree | 0bcbc9a11589d2c8e1957e22ec2b0d7b435c7a8e /fs/f2fs/gc.c | |
| parent | 796dbbfe4e52cc3ae860794fc20ea157391c4d93 (diff) | |
| download | op-kernel-dev-c13ff37e359bb3eacf4e1760dcea8d9760aa7459.zip op-kernel-dev-c13ff37e359bb3eacf4e1760dcea8d9760aa7459.tar.gz | |
f2fs: relax node version check for victim data in gc
- has_not_enough_free_secs
node_secs: 0 dent_secs: 0 freed:0 free_segments:103 reserved:104
- f2fs_gc
- get_victim_by_default
alloc_mode 0, gc_mode 1, max_search 2672, offset 4654, ofs_unit 1
- do_garbage_collect
start_segno 3976, end_segno 3977 type 0
- is_alive
nid 22797, blkaddr 2131882, ofs_in_node 0, version 0x8/0x0
- gc_data_segment 766, segno 3976, block 512/426 not alive
So, this patch fixes subtle corrupted case where node version does not match
to summary version which results in infinite loop by gc.
Reported-by: Yunlei He <heyunlei@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/gc.c')
| -rw-r--r-- | fs/f2fs/gc.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 63fefef..c52656c 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -555,8 +555,10 @@ static bool is_alive(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, get_node_info(sbi, nid, dni); if (sum->version != dni->version) { - f2fs_put_page(node_page, 1); - return false; + f2fs_msg(sbi->sb, KERN_WARNING, + "%s: valid data with mismatched node version.", + __func__); + set_sbi_flag(sbi, SBI_NEED_FSCK); } *nofs = ofs_of_node(node_page); |
