summaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-11-25 20:01:37 -0500
committerTheodore Ts'o <tytso@mit.edu>2014-11-25 20:01:37 -0500
commitbfcba2d0352f7916e98a1cec54c1c2473da6f4d6 (patch)
tree654f2cebb323496ec94f85c0934afe6aa1931613 /fs/ext4
parent31fc006b12f2c7e88fa5ee8f7f17ed0f85c9e4b8 (diff)
downloadop-kernel-dev-bfcba2d0352f7916e98a1cec54c1c2473da6f4d6.zip
op-kernel-dev-bfcba2d0352f7916e98a1cec54c1c2473da6f4d6.tar.gz
ext4: Remove an unnecessary check for NULL before iput()
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/mballoc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index f1c25f8..8d1e602 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2712,8 +2712,7 @@ int ext4_mb_release(struct super_block *sb)
}
kfree(sbi->s_mb_offsets);
kfree(sbi->s_mb_maxs);
- if (sbi->s_buddy_cache)
- iput(sbi->s_buddy_cache);
+ iput(sbi->s_buddy_cache);
if (sbi->s_mb_stats) {
ext4_msg(sb, KERN_INFO,
"mballoc: %u blocks %u reqs (%u success)",
OpenPOWER on IntegriCloud