summaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorZhang Zhen <zhenzhang.zhang@huawei.com>2014-05-12 09:57:59 -0400
committerTheodore Ts'o <tytso@mit.edu>2014-05-12 09:57:59 -0400
commit230b8c1a7b388ac5e06549a7dbe083568875804e (patch)
treed1291f679566ab473016a687e17c4155c7f3f6ea /fs/ext4
parent1c8349a17137b93f0a83f276c764a6df1b9a116e (diff)
downloadop-kernel-dev-230b8c1a7b388ac5e06549a7dbe083568875804e.zip
op-kernel-dev-230b8c1a7b388ac5e06549a7dbe083568875804e.tar.gz
ext4: avoid unneeded lookup when xattr name is invalid
In ext4_xattr_set_handle() we have checked the xattr name's length. So we should also check it in ext4_xattr_get() to avoid unneeded lookup caused by invalid name. Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/xattr.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
index 4eec399..c6ae6fa 100644
--- a/fs/ext4/xattr.c
+++ b/fs/ext4/xattr.c
@@ -369,6 +369,9 @@ ext4_xattr_get(struct inode *inode, int name_index, const char *name,
{
int error;
+ if (strlen(name) > 255)
+ return -ERANGE;
+
down_read(&EXT4_I(inode)->xattr_sem);
error = ext4_xattr_ibody_get(inode, name_index, name, buffer,
buffer_size);
OpenPOWER on IntegriCloud