summaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2011-01-10 12:51:28 -0500
committerTheodore Ts'o <tytso@mit.edu>2011-01-10 12:51:28 -0500
commit1c5b9e9065567876c2d4a7a16d78f0fed154a5bf (patch)
tree67b74f12c7336a972de54d004455369eec38bc28 /fs/ext4
parenta5196f8cdfbf6ccb20f093aaf48852d6d23b4e0b (diff)
downloadop-kernel-dev-1c5b9e9065567876c2d4a7a16d78f0fed154a5bf.zip
op-kernel-dev-1c5b9e9065567876c2d4a7a16d78f0fed154a5bf.tar.gz
ext4: fix memory leak in ext4_free_branches
Commit 40389687 moved a call to ext4_forget() out of ext4_free_branches and let ext4_free_blocks() handle calling bforget(). But that change unfortunately did not replace the call to ext4_forget() with brelse(), which was needed to drop the in-use count of the indirect block's buffer head, which lead to a memory leak when deleting files that used indirect blocks. Fix this. Thanks to Hugh Dickins for pointing this out. Cc: stable@kernel.org Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/inode.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 84b6162..e80fc51 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4378,6 +4378,7 @@ static void ext4_free_branches(handle_t *handle, struct inode *inode,
(__le32 *) bh->b_data,
(__le32 *) bh->b_data + addr_per_block,
depth);
+ brelse(bh);
/*
* Everything below this this pointer has been
OpenPOWER on IntegriCloud