summaryrefslogtreecommitdiffstats
path: root/fs/ext4/move_extent.c
diff options
context:
space:
mode:
authorDmitry Monakhov <dmonakhov@openvz.org>2012-09-26 12:32:54 -0400
committerTheodore Ts'o <tytso@mit.edu>2012-09-26 12:32:54 -0400
commitf066055a3449f0e5b0ae4f3ceab4445bead47638 (patch)
treec9232f08e2594b5e7f877facc2069e67847960eb /fs/ext4/move_extent.c
parent03bd8b9b896c8e940f282f540e6b4de90d666b7c (diff)
downloadop-kernel-dev-f066055a3449f0e5b0ae4f3ceab4445bead47638.zip
op-kernel-dev-f066055a3449f0e5b0ae4f3ceab4445bead47638.tar.gz
ext4: online defrag is not supported for journaled files
Proper block swap for inodes with full journaling enabled is truly non obvious task. In order to be on a safe side let's explicitly disable it for now. Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu> Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/move_extent.c')
-rw-r--r--fs/ext4/move_extent.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index df5cde5..e2016f3 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -1142,7 +1142,12 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp,
orig_inode->i_ino, donor_inode->i_ino);
return -EINVAL;
}
-
+ /* TODO: This is non obvious task to swap blocks for inodes with full
+ jornaling enabled */
+ if (ext4_should_journal_data(orig_inode) ||
+ ext4_should_journal_data(donor_inode)) {
+ return -EINVAL;
+ }
/* Protect orig and donor inodes against a truncate */
mext_inode_double_lock(orig_inode, donor_inode);
OpenPOWER on IntegriCloud