diff options
author | Davidlohr Bueso <dave@stgolabs.net> | 2015-11-06 16:33:04 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-11-06 17:50:42 -0800 |
commit | 5f2a2d5d423d5337a1392fa016ec23a8a4206006 (patch) | |
tree | 644e89ea4f70339d6b8f3dddc76132a1f90f8e62 /fs/ext4/indirect.c | |
parent | cb7ae262e230064ba282094b7e1f60a092448b72 (diff) | |
download | op-kernel-dev-5f2a2d5d423d5337a1392fa016ec23a8a4206006.zip op-kernel-dev-5f2a2d5d423d5337a1392fa016ec23a8a4206006.tar.gz |
ipc,msg: drop dst nil validation in copy_msg
d0edd8528362 ("ipc: convert invalid scenarios to use WARN_ON") relaxed the
nil dst parameter check, originally being a full BUG_ON. However, this
check seems quite unnecessary when the only purpose is for
ceckpoint/restore (MSG_COPY flag):
o The copy variable is set initially to nil, apparently as a way of
ensuring that prepare_copy is previously called. Which is in fact done,
unconditionally at the beginning of do_msgrcv.
o There is no concurrency with 'copy' (stack allocated in do_msgrcv).
Furthermore, any errors in 'copy' (and thus prepare_copy/copy_msg) should
always handled by IS_ERR() family. Therefore remove this check altogether
as it can never occur with the current users.
Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/ext4/indirect.c')
0 files changed, 0 insertions, 0 deletions