diff options
| author | Theodore Ts'o <tytso@mit.edu> | 2010-01-24 14:34:07 -0500 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2010-01-24 14:34:07 -0500 |
| commit | 19f5fb7ad679bb361222c7916086435020c37cce (patch) | |
| tree | 9e301163075c4faaf340cf50afd51855c76acd8c /fs/ext4/ialloc.c | |
| parent | d2eecb03936878ec574ade5532fa83df7d75dde7 (diff) | |
| download | op-kernel-dev-19f5fb7ad679bb361222c7916086435020c37cce.zip op-kernel-dev-19f5fb7ad679bb361222c7916086435020c37cce.tar.gz | |
ext4: Use bitops to read/modify EXT4_I(inode)->i_state
At several places we modify EXT4_I(inode)->i_state without holding
i_mutex (ext4_release_file, ext4_bmap, ext4_journalled_writepage,
ext4_do_update_inode, ...). These modifications are racy and we can
lose updates to i_state. So convert handling of i_state to use bitops
which are atomic.
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/ialloc.c')
| -rw-r--r-- | fs/ext4/ialloc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index f3624ea..2fab5ad 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -1029,7 +1029,8 @@ got: inode->i_generation = sbi->s_next_generation++; spin_unlock(&sbi->s_next_gen_lock); - ei->i_state = EXT4_STATE_NEW; + ei->i_state_flags = 0; + ext4_set_inode_state(inode, EXT4_STATE_NEW); ei->i_extra_isize = EXT4_SB(sb)->s_want_extra_isize; |
