summaryrefslogtreecommitdiffstats
path: root/fs/ext4/fsync.c
diff options
context:
space:
mode:
authorDmitry Monakhov <dmonakhov@openvz.org>2013-06-12 22:38:04 -0400
committerTheodore Ts'o <tytso@mit.edu>2013-06-12 22:38:04 -0400
commit4418e14112e3ca85e8492a4489a3552b0cc526a8 (patch)
tree93abfabff161cc2f5b09d7aaf6aa4ae09ba13c7b /fs/ext4/fsync.c
parent06a407f13daf9e48f0ef7189c7e54082b53940c7 (diff)
downloadop-kernel-dev-4418e14112e3ca85e8492a4489a3552b0cc526a8.zip
op-kernel-dev-4418e14112e3ca85e8492a4489a3552b0cc526a8.tar.gz
ext4: Fix fsync error handling after filesystem abort
If filesystem was aborted after inode's write back is complete but before its metadata was updated we may return success results in data loss. In order to handle fs abort correctly we have to check fs state once we discover that it is in MS_RDONLY state Test case: http://patchwork.ozlabs.org/patch/244297 Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/fsync.c')
-rw-r--r--fs/ext4/fsync.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index fc938eb..a8bc47f 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -98,8 +98,13 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
trace_ext4_sync_file_enter(file, datasync);
- if (inode->i_sb->s_flags & MS_RDONLY)
+ if (inode->i_sb->s_flags & MS_RDONLY) {
+ /* Make sure that we read updated s_mount_flags value */
+ smp_rmb();
+ if (EXT4_SB(inode->i_sb)->s_mount_flags & EXT4_MF_FS_ABORTED)
+ ret = -EROFS;
goto out;
+ }
if (!journal) {
ret = generic_file_fsync(file, start, end, datasync);
OpenPOWER on IntegriCloud