summaryrefslogtreecommitdiffstats
path: root/fs/ext3
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-02-21 11:58:54 +0300
committerJan Kara <jack@suse.cz>2014-03-03 11:31:00 +0100
commitf8cb556fdbc36855ef884061a1beec6124314c89 (patch)
tree72759be92241397da5a9f3017720a87b94460a8a /fs/ext3
parent7d6c2113505eb88a09949ed671d51c8c01cf7bb6 (diff)
downloadop-kernel-dev-f8cb556fdbc36855ef884061a1beec6124314c89.zip
op-kernel-dev-f8cb556fdbc36855ef884061a1beec6124314c89.tar.gz
ext3: remove unneeded check in ext3_ordered_writepage()
We already know "ret" is zero so there is no need to do: if (!ret) ret = err; We can just assign ret directly instead. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext3')
-rw-r--r--fs/ext3/inode.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 384b6eb..491f022 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,
* block_write_full_page() succeeded. Otherwise they are unmapped,
* and generally junk.
*/
- if (ret == 0) {
- err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
+ if (ret == 0)
+ ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
NULL, journal_dirty_data_fn);
- if (!ret)
- ret = err;
- }
walk_page_buffers(handle, page_bufs, 0,
PAGE_CACHE_SIZE, NULL, bput_one);
err = ext3_journal_stop(handle);
OpenPOWER on IntegriCloud