summaryrefslogtreecommitdiffstats
path: root/fs/ext2
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2016-08-09 10:07:52 +0200
committerJan Kara <jack@suse.cz>2016-08-09 10:12:28 +0200
commitf7a1c358e51c21b80336413fb824e1a82df648b9 (patch)
treef0c30066ab4ac93472b3d24324900f95022bb966 /fs/ext2
parent81abf2525827b29839a78fd55ab0699f033c41a5 (diff)
downloadop-kernel-dev-f7a1c358e51c21b80336413fb824e1a82df648b9.zip
op-kernel-dev-f7a1c358e51c21b80336413fb824e1a82df648b9.tar.gz
ext2: Check return value from ext2_get_group_desc()
ext2_get_group_desc() can return NULL if there is some error. This usually means there is some programming error in the ext2 driver itself but let's be defensive and handle that case. Coverity-id: 115628 Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs/ext2')
-rw-r--r--fs/ext2/ialloc.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index efe5fb2..04e73a9 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -465,6 +465,11 @@ struct inode *ext2_new_inode(struct inode *dir, umode_t mode,
for (i = 0; i < sbi->s_groups_count; i++) {
gdp = ext2_get_group_desc(sb, group, &bh2);
+ if (!gdp) {
+ if (++group == sbi->s_groups_count)
+ group = 0;
+ continue;
+ }
brelse(bitmap_bh);
bitmap_bh = read_inode_bitmap(sb, group);
if (!bitmap_bh) {
OpenPOWER on IntegriCloud