diff options
author | Kirill Korotaev <dev@sw.ru> | 2006-09-29 02:00:05 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 09:18:12 -0700 |
commit | 3b9b8ab65d8eed784b9164d03807cb2bda7b5cd6 (patch) | |
tree | 104c7b01768acd7e152cbf66e4868a73804e8af9 /fs/exec.c | |
parent | fc09561d6392771a392dea55c287de7e849b6b63 (diff) | |
download | op-kernel-dev-3b9b8ab65d8eed784b9164d03807cb2bda7b5cd6.zip op-kernel-dev-3b9b8ab65d8eed784b9164d03807cb2bda7b5cd6.tar.gz |
[PATCH] Fix unserialized task->files changing
Fixed race on put_files_struct on exec with proc. Restoring files on
current on error path may lead to proc having a pointer to already kfree-d
files_struct.
->files changing at exit.c and khtread.c are safe as exit_files() makes all
things under lock.
Found during OpenVZ stress testing.
[akpm@osdl.org: add export]
Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Signed-off-by: Kirill Korotaev <dev@openvz.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/exec.c')
-rw-r--r-- | fs/exec.c | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -898,8 +898,7 @@ int flush_old_exec(struct linux_binprm * bprm) return 0; mmap_failed: - put_files_struct(current->files); - current->files = files; + reset_files_struct(current, files); out: return retval; } |