diff options
| author | Peter Zijlstra <peterz@infradead.org> | 2014-05-21 17:32:19 +0200 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2014-06-06 07:54:02 +0200 |
| commit | e041e328c4b41e1db79bfe5ba9992c2ed771ad19 (patch) | |
| tree | 88f8689160ae586c728e6ef665cc4c580c116ba9 /fs/exec.c | |
| parent | 22c91aa23547a4363fd2a9ffddde95c899ac8aa0 (diff) | |
| download | op-kernel-dev-e041e328c4b41e1db79bfe5ba9992c2ed771ad19.zip op-kernel-dev-e041e328c4b41e1db79bfe5ba9992c2ed771ad19.tar.gz | |
perf: Fix perf_event_comm() vs. exec() assumption
perf_event_comm() assumes that set_task_comm() is only called on
exec(), and in particular that its only called on current.
Neither are true, as Dave reported a WARN triggered by set_task_comm()
being called on !current.
Separate the exec() hook from the comm hook.
Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/20140521153219.GH5226@laptop.programming.kicks-ass.net
[ Build fix. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'fs/exec.c')
| -rw-r--r-- | fs/exec.c | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -1110,6 +1110,7 @@ void setup_new_exec(struct linux_binprm * bprm) else set_dumpable(current->mm, suid_dumpable); + perf_event_exec(); set_task_comm(current, kbasename(bprm->filename)); /* Set the new mm task size. We have to do that late because it may |
