summaryrefslogtreecommitdiffstats
path: root/fs/dlm/requestqueue.h
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2006-10-31 11:55:56 -0600
committerSteven Whitehouse <swhiteho@redhat.com>2006-11-30 10:35:10 -0500
commitd4400156d415540086c34a06e5d233122d6bf56a (patch)
tree747e4d270fb453d57926d6b6cab564664d9d2c0f /fs/dlm/requestqueue.h
parent435618b75b82b5ee511cc01fcdda9c44adb2f4bd (diff)
downloadop-kernel-dev-d4400156d415540086c34a06e5d233122d6bf56a.zip
op-kernel-dev-d4400156d415540086c34a06e5d233122d6bf56a.tar.gz
[DLM] fix requestqueue race
Red Hat BZ 211914 There's a race between dlm_recoverd (1) enabling locking and (2) clearing out the requestqueue, and dlm_recvd (1) checking if locking is enabled and (2) adding a message to the requestqueue. An order of recoverd(1), recvd(1), recvd(2), recoverd(2) will result in a message being left on the requestqueue. The fix is to have dlm_recvd check if dlm_recoverd has enabled locking after taking the mutex for the requestqueue and if it has processing the message instead of queueing it. Signed-off-by: David Teigland <teigland@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Diffstat (limited to 'fs/dlm/requestqueue.h')
-rw-r--r--fs/dlm/requestqueue.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/dlm/requestqueue.h b/fs/dlm/requestqueue.h
index 349f0d2..6a53ea0 100644
--- a/fs/dlm/requestqueue.h
+++ b/fs/dlm/requestqueue.h
@@ -13,7 +13,7 @@
#ifndef __REQUESTQUEUE_DOT_H__
#define __REQUESTQUEUE_DOT_H__
-void dlm_add_requestqueue(struct dlm_ls *ls, int nodeid, struct dlm_header *hd);
+int dlm_add_requestqueue(struct dlm_ls *ls, int nodeid, struct dlm_header *hd);
int dlm_process_requestqueue(struct dlm_ls *ls);
void dlm_wait_requestqueue(struct dlm_ls *ls);
void dlm_purge_requestqueue(struct dlm_ls *ls);
OpenPOWER on IntegriCloud