summaryrefslogtreecommitdiffstats
path: root/fs/dcookies.c
diff options
context:
space:
mode:
authorMiklos Szeredi <miklos@szeredi.hu>2005-07-07 17:57:29 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-07 18:23:52 -0700
commit732dbef606f22a23cb3e1029d613977ec645e8ae (patch)
tree513e7230a59a526a09b387b5a2628a2eed3a80bb /fs/dcookies.c
parent484e389c63472a7f8cfb491cf11b047364e59365 (diff)
downloadop-kernel-dev-732dbef606f22a23cb3e1029d613977ec645e8ae.zip
op-kernel-dev-732dbef606f22a23cb3e1029d613977ec645e8ae.tar.gz
[PATCH] dcookies.c: use proper refcounting functions
Dcookies shouldn't play with the internals of dentry and vfsmnt refcounting. It defeats grepping, and is prone to break if implementation details change. In addition the function doesn't even seem to be performance critical: it calls kmem_cache_alloc(). Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Acked-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/dcookies.c')
-rw-r--r--fs/dcookies.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/dcookies.c b/fs/dcookies.c
index 581aac9..02aa0dd 100644
--- a/fs/dcookies.c
+++ b/fs/dcookies.c
@@ -94,12 +94,10 @@ static struct dcookie_struct * alloc_dcookie(struct dentry * dentry,
if (!dcs)
return NULL;
- atomic_inc(&dentry->d_count);
- atomic_inc(&vfsmnt->mnt_count);
dentry->d_cookie = dcs;
- dcs->dentry = dentry;
- dcs->vfsmnt = vfsmnt;
+ dcs->dentry = dget(dentry);
+ dcs->vfsmnt = mntget(vfsmnt);
hash_dcookie(dcs);
return dcs;
OpenPOWER on IntegriCloud