diff options
author | NeilBrown <neilb@suse.de> | 2014-07-14 11:28:20 +1000 |
---|---|---|
committer | Trond Myklebust <trond.myklebust@primarydata.com> | 2014-08-03 17:14:13 -0400 |
commit | f682a398b2e24ae0a775ddf37cced83b897198ee (patch) | |
tree | fdc9c26acf383d15be516af64bb7e66d6a780989 /fs/dcache.c | |
parent | 1fa1e38447964d6c96b027f9f999ef105d8cf8aa (diff) | |
download | op-kernel-dev-f682a398b2e24ae0a775ddf37cced83b897198ee.zip op-kernel-dev-f682a398b2e24ae0a775ddf37cced83b897198ee.tar.gz |
NFS: allow lockless access to access_cache
The access cache is used during RCU-walk path lookups, so it is best
to avoid locking if possible as taking a lock kills concurrency.
The rbtree is not rcu-safe and cannot easily be made so.
Instead we simply check the last (i.e. most recent) entry on the LRU
list. If this doesn't match, then we return -ECHILD and retry in
lock/refcount mode.
This requires freeing the nfs_access_entry struct with rcu, and
requires using rcu access primatives when adding entries to the lru, and
when examining the last entry.
Calling put_rpccred before kfree_rcu looks a bit odd, but as
put_rpccred already provides rcu protection, we know that the cred will
not actually be freed until the next grace period, so any concurrent
access will be safe.
This patch provides about 5% performance improvement on a stat-heavy
synthetic work load with 4 threads on a 2-core CPU.
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Diffstat (limited to 'fs/dcache.c')
0 files changed, 0 insertions, 0 deletions