diff options
author | Jeff Mahoney <jeffm@suse.com> | 2010-03-23 13:35:39 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-03-24 16:31:21 -0700 |
commit | 3f8b5ee33293d43ca360771b535dfae8c57259dc (patch) | |
tree | f533b80b6ad553882e81799b17e0cf94e41bf70e /fs/dcache.c | |
parent | 6cb4aff0a77cc0e6bae9475d62205319e3ebbf3f (diff) | |
download | op-kernel-dev-3f8b5ee33293d43ca360771b535dfae8c57259dc.zip op-kernel-dev-3f8b5ee33293d43ca360771b535dfae8c57259dc.tar.gz |
reiserfs: properly honor read-only devices
The reiserfs journal behaves inconsistently when determining whether to
allow a mount of a read-only device.
This is due to the use of the continue_replay variable to short circuit
the journal scanning. If it's set, it's assumed that there are
transactions to replay, but there may not be. If it's unset, it's assumed
that there aren't any, and that may not be the case either.
I've observed two failure cases:
1) Where a clean file system on a read-only device refuses to mount
2) Where a clean file system on a read-only device passes the
optimization and then tries writing the journal header to update
the latest mount id.
The former is easily observable by using a freshly created file system on
a read-only loopback device.
This patch moves the check into journal_read_transaction, where it can
bail out before it's about to replay a transaction. That way it can go
through and skip transactions where appropriate, yet still refuse to mount
a file system with outstanding transactions.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/dcache.c')
0 files changed, 0 insertions, 0 deletions