summaryrefslogtreecommitdiffstats
path: root/fs/cifs
diff options
context:
space:
mode:
authorMichael Opdenacker <michael.opdenacker@free-electrons.com>2014-04-15 10:06:50 +0200
committerSteve French <smfrench@gmail.com>2014-04-16 23:08:57 -0500
commit1f80c0cc39e587edd06a36b43ba3a3b09d4ac428 (patch)
tree68539f36bda4fae674846affe1f8464197f7371a /fs/cifs
parentbae9f746a18ee31bbeeb25ae6615805ed6eca173 (diff)
downloadop-kernel-dev-1f80c0cc39e587edd06a36b43ba3a3b09d4ac428.zip
op-kernel-dev-1f80c0cc39e587edd06a36b43ba3a3b09d4ac428.tar.gz
cif: fix dead code
This issue was found by Coverity (CID 1202536) This proposes a fix for a statement that creates dead code. The "rc < 0" statement is within code that is run with "rc > 0". It seems like "err < 0" was meant to be used here. This way, the error code is returned by the function. Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com> Acked-by: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs')
-rw-r--r--fs/cifs/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/file.c b/fs/cifs/file.c
index a875eed..5ed03e0 100644
--- a/fs/cifs/file.c
+++ b/fs/cifs/file.c
@@ -2599,7 +2599,7 @@ cifs_writev(struct kiocb *iocb, const struct iovec *iov,
ssize_t err;
err = generic_write_sync(file, iocb->ki_pos - rc, rc);
- if (rc < 0)
+ if (err < 0)
rc = err;
}
} else {
OpenPOWER on IntegriCloud