summaryrefslogtreecommitdiffstats
path: root/fs/cifs
diff options
context:
space:
mode:
authorSteve French <sfrench@us.ibm.com>2009-08-31 15:27:26 +0000
committerSteve French <sfrench@us.ibm.com>2009-08-31 15:27:26 +0000
commit2920ee2b47fc8e6aebe1d1956b2725f48fa93cc5 (patch)
treed6c65477946df8f136800e813da52df55e65919c /fs/cifs
parent7b2aa037e878c939676675969983284a02958ae3 (diff)
downloadop-kernel-dev-2920ee2b47fc8e6aebe1d1956b2725f48fa93cc5.zip
op-kernel-dev-2920ee2b47fc8e6aebe1d1956b2725f48fa93cc5.tar.gz
[CIFS] potential NULL dereference in parse_DFS_referrals()
memory allocation may fail, prevent a NULL dereference Pointed out by Roel Kluin CC: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs')
-rw-r--r--fs/cifs/cifssmb.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c
index 1866bc2..5f0b80d 100644
--- a/fs/cifs/cifssmb.c
+++ b/fs/cifs/cifssmb.c
@@ -3961,6 +3961,10 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
if (is_unicode) {
__le16 *tmp = kmalloc(strlen(searchName)*2 + 2,
GFP_KERNEL);
+ if (tmp == NULL) {
+ rc = -ENOMEM;
+ goto parse_DFS_referrals_exit;
+ }
cifsConvertToUCS((__le16 *) tmp, searchName,
PATH_MAX, nls_codepage, remap);
node->path_consumed = cifs_ucs2_bytes(tmp,
OpenPOWER on IntegriCloud