summaryrefslogtreecommitdiffstats
path: root/fs/cifs
diff options
context:
space:
mode:
authorSteve French <smfrench@gmail.com>2015-03-27 01:15:02 -0500
committerSteve French <smfrench@gmail.com>2015-04-01 00:01:47 -0500
commitc85c35f8fc1d3f5ca60cd713f10af387de73cb94 (patch)
tree2c074253f31dc4095b192b2c311f0039c70083d7 /fs/cifs
parent064bcc0702a83aed29220bee3b3db3f968c5d8ae (diff)
downloadop-kernel-dev-c85c35f8fc1d3f5ca60cd713f10af387de73cb94.zip
op-kernel-dev-c85c35f8fc1d3f5ca60cd713f10af387de73cb94.tar.gz
Fix warning on impossible comparison
workstation_RFC1001_name is part of the struct and can't be null, remove impossible comparison (array vs. null) Pointed out by Coverity (CID 140095) Signed-off-by: Steve French <smfrench@gmail.com> Reviewed-by: Jeff Layton <jlayton@samba.org>
Diffstat (limited to 'fs/cifs')
-rw-r--r--fs/cifs/connect.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index cdb1aaf..480cf9c 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server)
* calling name ends in null (byte 16) from old smb
* convention.
*/
- if (server->workstation_RFC1001_name &&
- server->workstation_RFC1001_name[0] != 0)
+ if (server->workstation_RFC1001_name[0] != 0)
rfc1002mangle(ses_init_buf->trailer.
session_req.calling_name,
server->workstation_RFC1001_name,
OpenPOWER on IntegriCloud