summaryrefslogtreecommitdiffstats
path: root/fs/cifs/sess.c
diff options
context:
space:
mode:
authorJeff Layton <jlayton@redhat.com>2013-05-24 07:41:01 -0400
committerSteve French <smfrench@gmail.com>2013-06-24 01:56:40 -0500
commit3534b8508e4b21eec0b7b839f7234a9b6fe27d03 (patch)
treeabca5bc7bb74168ffb6a8a9ff09cd99a3217f639 /fs/cifs/sess.c
parent7d066459697610f6e755a7cfe199c3c6b142fb85 (diff)
downloadop-kernel-dev-3534b8508e4b21eec0b7b839f7234a9b6fe27d03.zip
op-kernel-dev-3534b8508e4b21eec0b7b839f7234a9b6fe27d03.tar.gz
cifs: throw a warning if negotiate or sess_setup ops are passed NULL server or session pointers
These look pretty cargo-culty to me, but let's be certain. Leave them in place for now. Pop a WARN if it ever does happen. Also, move to a more standard idiom for setting the "server" pointer. Signed-off-by: Jeff Layton <jlayton@redhat.com> Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/sess.c')
-rw-r--r--fs/cifs/sess.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/cifs/sess.c b/fs/cifs/sess.c
index 838e224..e8c5dc9 100644
--- a/fs/cifs/sess.c
+++ b/fs/cifs/sess.c
@@ -576,8 +576,10 @@ CIFS_SessSetup(const unsigned int xid, struct cifs_ses *ses,
u16 blob_len;
char *ntlmsspblob = NULL;
- if (ses == NULL)
+ if (ses == NULL) {
+ WARN(1, "%s: ses == NULL!", __func__);
return -EINVAL;
+ }
type = ses->server->secType;
cifs_dbg(FYI, "sess setup type %d\n", type);
OpenPOWER on IntegriCloud