diff options
| author | Steve French <sfrench@us.ibm.com> | 2011-02-08 23:52:32 +0000 |
|---|---|---|
| committer | Steve French <sfrench@us.ibm.com> | 2011-02-08 23:52:32 +0000 |
| commit | 7e90d705fc9f8c5e3a1549281dce0654d049243b (patch) | |
| tree | 36752aa5c1005716d2ce91cbf020ab8c2602f129 /fs/cifs/connect.c | |
| parent | 100b33c8bd8a3235fd0b7948338d6cbb3db3c63d (diff) | |
| download | op-kernel-dev-7e90d705fc9f8c5e3a1549281dce0654d049243b.zip op-kernel-dev-7e90d705fc9f8c5e3a1549281dce0654d049243b.tar.gz | |
[CIFS] Do not send SMBEcho requests on new sockets until SMBNegotiate
In order to determine whether an SMBEcho request can be sent
we need to know that the socket is established (server tcpStatus == CifsGood)
AND that an SMB NegotiateProtocol has been sent (server maxBuf != 0).
Without the second check we can send an Echo request during reconnection
before the server can accept it.
CC: JG <jg@cms.ac>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/connect.c')
| -rw-r--r-- | fs/cifs/connect.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 257b6d8..10011e9 100644 --- a/fs/cifs/connect.c +++ b/fs/cifs/connect.c @@ -341,7 +341,7 @@ cifs_echo_request(struct work_struct *work) * We cannot send an echo until the NEGOTIATE_PROTOCOL request is done. * Also, no need to ping if we got a response recently */ - if (server->tcpStatus != CifsGood || + if ((server->tcpStatus != CifsGood) || (server->maxBuf == 0) || time_before(jiffies, server->lstrp + SMB_ECHO_INTERVAL - HZ)) goto requeue_echo; |
