diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-04-30 17:30:24 +0300 |
|---|---|---|
| committer | Steve French <smfrench@gmail.com> | 2015-05-20 11:36:16 -0500 |
| commit | 65c3b205ebe06a389a29544e71a8071da0ce4155 (patch) | |
| tree | 6f8a9c996c0d4497fdf3e614082a3f0ae206b8dc /fs/cifs/cifssmb.c | |
| parent | 1dc92c450a53f120b67296cb4b29c1dfdc665ac1 (diff) | |
| download | op-kernel-dev-65c3b205ebe06a389a29544e71a8071da0ce4155.zip op-kernel-dev-65c3b205ebe06a389a29544e71a8071da0ce4155.tar.gz | |
CIFS: remove an unneeded NULL check
Smatch complains because we dereference "ses->server" without checking
some lines earlier inside the call to get_next_mid(ses->server).
fs/cifs/cifssmb.c:4921 CIFSGetDFSRefer()
warn: variable dereferenced before check 'ses->server' (see line 4899)
There is only one caller for this function get_dfs_path() and it always
passes a non-null "ses->server" pointer so this NULL check can be
removed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steve French <smfrench@gmail.com>
Diffstat (limited to 'fs/cifs/cifssmb.c')
| -rw-r--r-- | fs/cifs/cifssmb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/cifssmb.c b/fs/cifs/cifssmb.c index 1091aff..f26ffbf 100644 --- a/fs/cifs/cifssmb.c +++ b/fs/cifs/cifssmb.c @@ -4918,7 +4918,7 @@ getDFSRetry: strncpy(pSMB->RequestFileName, search_name, name_len); } - if (ses->server && ses->server->sign) + if (ses->server->sign) pSMB->hdr.Flags2 |= SMBFLG2_SECURITY_SIGNATURE; pSMB->hdr.Uid = ses->Suid; |
