summaryrefslogtreecommitdiffstats
path: root/fs/cifs/CHANGES
diff options
context:
space:
mode:
authorSteve French <sfrench@us.ibm.com>2007-11-08 17:57:40 +0000
committerSteve French <sfrench@us.ibm.com>2007-11-08 17:57:40 +0000
commit15b0395911eb45a0834755f0d9e84570644a8c22 (patch)
treefacf56b663ab75c654448e65c763356cef2af305 /fs/cifs/CHANGES
parent9eae8a8903c3d90283d338fad2cc58f2eb90adcb (diff)
downloadop-kernel-dev-15b0395911eb45a0834755f0d9e84570644a8c22.zip
op-kernel-dev-15b0395911eb45a0834755f0d9e84570644a8c22.tar.gz
[CIFS] Fix incorrect mode when ACL had deny access control entries
When mounted with the cifsacl mount option, we were treating any deny ACEs found like allow ACEs and it turns out for SFU and SUA Windows set these type of access control entries often. The order of ACEs is important too. The canonical order that most ACL tools and Windows explorer consruct ACLs with is to begin with DENY entries then follow with ALLOW, otherwise an allow entry could be encountered first, making the subsequent deny entry like "dead code which would be superflous since Windows stops when a match is made for the operation you are trying to perform for your user We start with no permissions in the mode and build up as we find permissions (ie allow ACEs). This fixes deny ACEs so they affect the mask used to set the subsequent allow ACEs. Acked-by: Shirish Pargaonkar <shirishp@us.ibm.com> CC: Alexander Bokovoy <ab@samba.org> Signed-off-by: Steve French <sfrench@us.ibm.com>
Diffstat (limited to 'fs/cifs/CHANGES')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud