diff options
author | James Morris <jmorris@namei.org> | 2010-01-14 09:33:28 +1100 |
---|---|---|
committer | James Morris <jmorris@namei.org> | 2010-01-15 08:23:57 +1100 |
commit | 8d9525048c74786205b99f3fcd05a839721edfb7 (patch) | |
tree | e09c056c9888410aea680deda092ca9b85fc77e2 /fs/char_dev.c | |
parent | cd7bec6ad80188394a8ea857ff1aa3512fc2282a (diff) | |
download | op-kernel-dev-8d9525048c74786205b99f3fcd05a839721edfb7.zip op-kernel-dev-8d9525048c74786205b99f3fcd05a839721edfb7.tar.gz |
security: correct error returns for get/set security with private inodes
Currently, the getsecurity and setsecurity operations return zero for
kernel private inodes, where xattrs are not available directly to
userspace.
This confuses some applications, and does not conform to the
man page for getxattr(2) etc., which state that these syscalls
should return ENOTSUP if xattrs are not supported or disabled.
Note that in the listsecurity case, we still need to return zero
as we don't know which other xattr handlers may be active.
For discussion of userland confusion, see:
http://www.mail-archive.com/bug-coreutils@gnu.org/msg17988.html
This patch corrects the error returns so that ENOTSUP is reported
to userspace as required.
Signed-off-by: James Morris <jmorris@namei.org>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Serge Hallyn <serue@us.ibm.com>
Diffstat (limited to 'fs/char_dev.c')
0 files changed, 0 insertions, 0 deletions