diff options
| author | Sage Weil <sage@newdream.net> | 2011-05-12 15:28:11 -0700 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2011-05-19 11:25:04 -0700 |
| commit | da39822c6565095a0151ccf9d6b95e2ae5612885 (patch) | |
| tree | 7e69ca065c8ea5b4152e73f59347924f9edb02d8 /fs/ceph | |
| parent | 31456665a02148353a83fec84d3182700e356588 (diff) | |
| download | op-kernel-dev-da39822c6565095a0151ccf9d6b95e2ae5612885.zip op-kernel-dev-da39822c6565095a0151ccf9d6b95e2ae5612885.tar.gz | |
ceph: fix broken comparison in readdir loop
Both off and fi->offset are unsigned, so the difference is always >= 0.
Compare them directly instead of the sign of the difference.
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph')
| -rw-r--r-- | fs/ceph/dir.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 53a5eb4..33729e8 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c @@ -360,7 +360,7 @@ more: rinfo = &fi->last_readdir->r_reply_info; dout("readdir frag %x num %d off %d chunkoff %d\n", frag, rinfo->dir_nr, off, fi->offset); - while (off - fi->offset >= 0 && off - fi->offset < rinfo->dir_nr) { + while (off >= fi->offset && off - fi->offset < rinfo->dir_nr) { u64 pos = ceph_make_fpos(frag, off); struct ceph_mds_reply_inode *in = rinfo->dir_in[off - fi->offset].in; |
