diff options
| author | Henry C Chang <henry_c_chang@tcloudcomputing.com> | 2010-06-01 11:31:08 -0700 |
|---|---|---|
| committer | Sage Weil <sage@newdream.net> | 2010-06-01 16:55:55 -0700 |
| commit | 13a4214cd9ec14d7b77e98bd3ee51f60f868a6e5 (patch) | |
| tree | baf741b4b80b169994591870106a39a885b55a68 /fs/ceph/inode.c | |
| parent | 67a3e12b05e055c0415c556a315a3d3eb637e29e (diff) | |
| download | op-kernel-dev-13a4214cd9ec14d7b77e98bd3ee51f60f868a6e5.zip op-kernel-dev-13a4214cd9ec14d7b77e98bd3ee51f60f868a6e5.tar.gz | |
ceph: fix d_subdirs ordering problem
We misused list_move_tail() to order the dentry in d_subdirs.
This will screw up the d_subdirs order.
This bug can be reliably reproduced by:
1. mount ceph fs.
2. on ceph fs, git clone git://ceph.newdream.net/git/ceph.git
3. Run autogen.sh in ceph directory.
(Note: Errors only occur at the first time you run autogen.sh.)
Signed-off-by: Henry C Chang <henry_c_chang@tcloudcomputing.com>
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph/inode.c')
| -rw-r--r-- | fs/ceph/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c index 226f5a5..ab47f46 100644 --- a/fs/ceph/inode.c +++ b/fs/ceph/inode.c @@ -827,7 +827,7 @@ static void ceph_set_dentry_offset(struct dentry *dn) spin_lock(&dcache_lock); spin_lock(&dn->d_lock); - list_move_tail(&dir->d_subdirs, &dn->d_u.d_child); + list_move(&dn->d_u.d_child, &dir->d_subdirs); dout("set_dentry_offset %p %lld (%p %p)\n", dn, di->offset, dn->d_u.d_child.prev, dn->d_u.d_child.next); spin_unlock(&dn->d_lock); |
