diff options
author | Sage Weil <sage@newdream.net> | 2011-01-17 20:34:08 -0800 |
---|---|---|
committer | Sage Weil <sage@newdream.net> | 2011-03-21 12:24:19 -0700 |
commit | 6f6c7006755b667f9f6c1f3b6f08cd65f75cc471 (patch) | |
tree | 233e96acdc3b627c97267992368ae1cb6cd66a5f /fs/ceph/debugfs.c | |
parent | 09adc80c611bb8902daa8ccfe34dbbc009d6befe (diff) | |
download | op-kernel-dev-6f6c7006755b667f9f6c1f3b6f08cd65f75cc471.zip op-kernel-dev-6f6c7006755b667f9f6c1f3b6f08cd65f75cc471.tar.gz |
libceph: fix osd request queuing on osdmap updates
If we send a request to osd A, and the request's pg remaps to osd B and
then back to A in quick succession, we need to resend the request to A. The
old code was only calling kick_requests after processing all incremental
maps in a message, so it was very possible to not resend a request that
needed to be resent. This would make the osd eventually time out (at least
with the current default of osd timeouts enabled).
The correct approach is to scan requests on every map incremental. This
patch refactors the kick code in a few ways:
- all requests are either on req_lru (in flight), req_unsent (ready to
send), or req_notarget (currently map to no up osd)
- mapping always done by map_request (previous map_osds)
- if the mapping changes, we requeue. requests are resent only after all
map incrementals are processed.
- some osd reset code is moved out of kick_requests into a separate
function
- the "kick this osd" functionality is moved to kick_osd_requests, as it
is unrelated to scanning for request->pg->osd mapping changes
Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph/debugfs.c')
0 files changed, 0 insertions, 0 deletions