summaryrefslogtreecommitdiffstats
path: root/fs/buffer.c
diff options
context:
space:
mode:
authorDarrick J. Wong <darrick.wong@oracle.com>2014-10-14 02:35:49 -0400
committerTheodore Ts'o <tytso@mit.edu>2014-10-14 02:35:49 -0400
commit813d32f91333e4c33d5a19b67167c4bae42dae75 (patch)
tree09e1183d369c6b42a6fc3edcb73017ff54aa8a36 /fs/buffer.c
parentaef4885ae14f1df75b58395c5314d71f613d26d9 (diff)
downloadop-kernel-dev-813d32f91333e4c33d5a19b67167c4bae42dae75.zip
op-kernel-dev-813d32f91333e4c33d5a19b67167c4bae42dae75.tar.gz
ext4: check s_chksum_driver when looking for bg csum presence
Convert the ext4_has_group_desc_csum predicate to look for a checksum driver instead of the metadata_csum flag and change the bg checksum calculation function to look for GDT_CSUM before taking the crc16 path. Without this patch, if we mount with ^uninit_bg,^metadata_csum and later metadata_csum gets turned on by accident, the block group checksum functions will incorrectly assume that checksumming is enabled (metadata_csum) but that crc16 should be used (!s_chksum_driver). This is totally wrong, so fix the predicate and the checksum formula selection. (Granted, if the metadata_csum feature bit gets enabled on a live FS then something underhanded is going on, but we could at least avoid writing garbage into the on-disk fields.) Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Dmitry Monakhov <dmonakhov@openvz.org> Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/buffer.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud