summaryrefslogtreecommitdiffstats
path: root/fs/btrfs
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2014-08-17 15:09:21 -0500
committerChris Mason <clm@fb.com>2014-08-21 07:55:29 -0700
commita3c108950d8e0bfcf48856cc159956022a7ad925 (patch)
treee158d7b90824bea47a772c2386487aec62a2de3b /fs/btrfs
parent51f395ad4058883e4273b02fdebe98072dbdc0d2 (diff)
downloadop-kernel-dev-a3c108950d8e0bfcf48856cc159956022a7ad925.zip
op-kernel-dev-a3c108950d8e0bfcf48856cc159956022a7ad925.tar.gz
btrfs: fix leak in qgroup_subtree_accounting() error path
Coverity pointed this out; in the newly added qgroup_subtree_accounting(), if btrfs_find_all_roots() returns an error, we leak at least the parents pointer, and possibly the roots pointer, depending on what failure occurs. If btrfs_find_all_roots() returns an error, we need to free up all allocations before we return. "roots" is initialized to NULL, so it should be safe to free it unconditionally (ulist_free() handles that case). Cc: Mark Fasheh <mfasheh@suse.de> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Mark Fasheh <mfasheh@suse.de> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs')
-rw-r--r--fs/btrfs/qgroup.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index b497498..8abe455 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -1973,7 +1973,7 @@ static int qgroup_subtree_accounting(struct btrfs_trans_handle *trans,
elem.seq, &roots);
btrfs_put_tree_mod_seq(fs_info, &elem);
if (ret < 0)
- return ret;
+ goto out;
if (roots->nnodes != 1)
goto out;
OpenPOWER on IntegriCloud