diff options
| author | Filipe Manana <fdmanana@suse.com> | 2014-08-04 19:37:21 +0100 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-09-17 13:38:02 -0700 |
| commit | f98de9b9c07485f7e21edfd5b2b20c89d662af3c (patch) | |
| tree | cf83b225c48c5f3fa32be73c25ad4c20b087d580 /fs/btrfs/volumes.c | |
| parent | 79aec2b80db1089f983d60e4a22cb95d8b939844 (diff) | |
| download | op-kernel-dev-f98de9b9c07485f7e21edfd5b2b20c89d662af3c.zip op-kernel-dev-f98de9b9c07485f7e21edfd5b2b20c89d662af3c.tar.gz | |
Btrfs: make btrfs_search_forward return with nodes unlocked
None of the uses of btrfs_search_forward() need to have the path
nodes (level >= 1) read locked, only the leaf needs to be locked
while the caller processes it. Therefore make it return a path
with all nodes unlocked, except for the leaf.
This change is motivated by the observation that during a file
fsync we repeatdly call btrfs_search_forward() and process the
returned leaf while upper nodes of the returned path (level >= 1)
are read locked, which unnecessarily blocks other tasks that want
to write to the same fs/subvol btree.
Therefore instead of modifying the fsync code to unlock all nodes
with level >= 1 immediately after calling btrfs_search_forward(),
change btrfs_search_forward() to do it, so that it benefits all
callers.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/volumes.c')
| -rw-r--r-- | fs/btrfs/volumes.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 46cd29a..ff8386e 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -3625,8 +3625,6 @@ static int btrfs_uuid_scan_kthread(void *data) max_key.type = BTRFS_ROOT_ITEM_KEY; max_key.offset = (u64)-1; - path->keep_locks = 1; - while (1) { ret = btrfs_search_forward(root, &key, path, 0); if (ret) { |
