summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/relocation.c
diff options
context:
space:
mode:
authorWang Shilong <wangsl.fnst@cn.fujitsu.com>2013-12-28 19:52:39 +0800
committerChris Mason <clm@fb.com>2014-01-28 13:20:14 -0800
commit1708cc5723cb775703b42a0ce8e521019c42dd67 (patch)
tree2e9dfec779989b80010af96287d5d8babbe46796 /fs/btrfs/relocation.c
parente77751aad1facc4973613a11e2ad98ee4bbb04e1 (diff)
downloadop-kernel-dev-1708cc5723cb775703b42a0ce8e521019c42dd67.zip
op-kernel-dev-1708cc5723cb775703b42a0ce8e521019c42dd67.tar.gz
Btrfs: fix an oops when we fail to relocate tree blocks
During balance test, we hit an oops: [ 2013.841551] kernel BUG at fs/btrfs/relocation.c:1174! The problem is that if we fail to relocate tree blocks, we should update backref cache, otherwise, some pending nodes are not updated while snapshot check @cache->last_trans is within one transaction and won't update it and then oops happen. Signed-off-by: Wang Shilong <wangsl.fnst@cn.fujitsu.com> Signed-off-by: Josef Bacik <jbacik@fb.com> Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/relocation.c')
-rw-r--r--fs/btrfs/relocation.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 9189f9e..07b3b36 100644
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -4009,6 +4009,12 @@ restart:
if (!RB_EMPTY_ROOT(&blocks)) {
ret = relocate_tree_blocks(trans, rc, &blocks);
if (ret < 0) {
+ /*
+ * if we fail to relocate tree blocks, force to update
+ * backref cache when committing transaction.
+ */
+ rc->backref_cache.last_trans = trans->transid - 1;
+
if (ret != -EAGAIN) {
err = ret;
break;
OpenPOWER on IntegriCloud