diff options
| author | Filipe Manana <fdmanana@suse.com> | 2014-10-09 21:15:44 +0100 |
|---|---|---|
| committer | Chris Mason <clm@fb.com> | 2014-11-20 17:14:27 -0800 |
| commit | c44f649e281e93689827a206653696be9599a320 (patch) | |
| tree | 76b30f36b535f504a40f8f87451dc9456f01ef9d /fs/btrfs/inode.c | |
| parent | 4bcbb33255131adbe481c0467df26d654ce3bc78 (diff) | |
| download | op-kernel-dev-c44f649e281e93689827a206653696be9599a320.zip op-kernel-dev-c44f649e281e93689827a206653696be9599a320.tar.gz | |
Btrfs: make inode.c:compress_file_range() return void
Its return value is useless, its single caller ignores it and can't do
anything with it anyway, since it's a workqueue task and not the task
calling filemap_fdatawrite_range (writepages) nor filemap_fdatawait_range().
Failure is communicated to such functions via start and end of writeback
with the respective pages tagged with an error and AS_EIO flag set in the
inode's imapping.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
Diffstat (limited to 'fs/btrfs/inode.c')
| -rw-r--r-- | fs/btrfs/inode.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index 793e033..5a8a749 100644 --- a/fs/btrfs/inode.c +++ b/fs/btrfs/inode.c @@ -382,7 +382,7 @@ static inline int inode_need_compress(struct inode *inode) * are written in the same order that the flusher thread sent them * down. */ -static noinline int compress_file_range(struct inode *inode, +static noinline void compress_file_range(struct inode *inode, struct page *locked_page, u64 start, u64 end, struct async_cow *async_cow, @@ -620,8 +620,7 @@ cleanup_and_bail_uncompressed: *num_added += 1; } -out: - return ret; + return; free_pages_out: for (i = 0; i < nr_pages_ret; i++) { @@ -629,8 +628,6 @@ free_pages_out: page_cache_release(pages[i]); } kfree(pages); - - goto out; } static void free_async_extent_pages(struct async_extent *async_extent) |
