diff options
| author | Chris Mason <chris.mason@fusionio.com> | 2013-05-17 18:30:14 -0400 |
|---|---|---|
| committer | Chris Mason <chris.mason@fusionio.com> | 2013-05-17 21:52:52 -0400 |
| commit | 9be3395bcd4ad4af76476ac38152b4cafa6b6159 (patch) | |
| tree | a43b9ce18f66482abf055d87b3ceec02a84477e7 /fs/btrfs/disk-io.c | |
| parent | 667e7d94a1683661cff5fe9a0fa0d7f8fdd2c007 (diff) | |
| download | op-kernel-dev-9be3395bcd4ad4af76476ac38152b4cafa6b6159.zip op-kernel-dev-9be3395bcd4ad4af76476ac38152b4cafa6b6159.tar.gz | |
Btrfs: use a btrfs bioset instead of abusing bio internals
Btrfs has been pointer tagging bi_private and using bi_bdev
to store the stripe index and mirror number of failed IOs.
As bios bubble back up through the call chain, we use these
to decide if and how to retry our IOs. They are also used
to count IO failures on a per device basis.
Recently a bio tracepoint was added lead to crashes because
we were abusing bi_bdev.
This commit adds a btrfs bioset, and creates explicit fields
for the mirror number and stripe index. The plan is to
extend this structure for all of the fields currently in
struct btrfs_bio, which will mean one less kmalloc in
our IO path.
Signed-off-by: Chris Mason <chris.mason@fusionio.com>
Reported-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'fs/btrfs/disk-io.c')
| -rw-r--r-- | fs/btrfs/disk-io.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 4e9ebe1..ca0ea99 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -3128,7 +3128,7 @@ static int write_dev_flush(struct btrfs_device *device, int wait) * caller */ device->flush_bio = NULL; - bio = bio_alloc(GFP_NOFS, 0); + bio = btrfs_io_bio_alloc(GFP_NOFS, 0); if (!bio) return -ENOMEM; |
