summaryrefslogtreecommitdiffstats
path: root/fs/btrfs/acl.c
diff options
context:
space:
mode:
authorJosef Bacik <jbacik@redhat.com>2007-11-19 10:18:17 -0500
committerChris Mason <chris.mason@oracle.com>2008-09-25 11:03:57 -0400
commit1caf9342fc71d020e788a59598a44d4ea0136b36 (patch)
treee54d756bd124515b262f56b22cd9c169b8b00027 /fs/btrfs/acl.c
parent5cf664263b05beb080bf95037e4c3bd50c80b096 (diff)
downloadop-kernel-dev-1caf9342fc71d020e788a59598a44d4ea0136b36.zip
op-kernel-dev-1caf9342fc71d020e788a59598a44d4ea0136b36.tar.gz
Btrfs: Make ACLs return EOPNOTSUPP for now
There was a slight problem with ACL's returning EINVAL when you tried to set an ACL. This isn't correct, we should be returning EOPNOTSUPP, so I did a very ugly thing and just commented everybody out and made them return EOPNOTSUPP. This is only temporary, I'm going back to implement ACL's, but Chris wants to push out a release so this will suffice for now. Also Yan suggested setting reada to -1 in the delete case to enable backwards readahead, and in the listxattr case I moved path->reada = 2; to after the if (!path) check so we can avoid a possible null dereference. Thank you, Signed-off-by: Chris Mason <chris.mason@oracle.com>
Diffstat (limited to 'fs/btrfs/acl.c')
-rw-r--r--fs/btrfs/acl.c18
1 files changed, 18 insertions, 0 deletions
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index aee9f06..889ba89 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -23,32 +23,50 @@
#include "ctree.h"
#include "xattr.h"
+/*
+ * FIXME: At this point this is all place holder stuff, we just return
+ * -EOPNOTSUPP so cp won't complain when it tries to copy over a file with an
+ * acl on it.
+ */
+
static int btrfs_xattr_acl_access_get(struct inode *inode, const char *name,
void *value, size_t size)
{
+ /*
return btrfs_xattr_get(inode, BTRFS_XATTR_INDEX_POSIX_ACL_ACCESS, name,
value, size);
+ */
+ return -EOPNOTSUPP;
}
static int btrfs_xattr_acl_access_set(struct inode *inode, const char *name,
const void *value, size_t size, int flags)
{
+ /*
return btrfs_xattr_set(inode, BTRFS_XATTR_INDEX_POSIX_ACL_ACCESS, name,
value, size, flags);
+ */
+ return -EOPNOTSUPP;
}
static int btrfs_xattr_acl_default_get(struct inode *inode, const char *name,
void *value, size_t size)
{
+ /*
return btrfs_xattr_get(inode, BTRFS_XATTR_INDEX_POSIX_ACL_DEFAULT,
name, value, size);
+ */
+ return -EOPNOTSUPP;
}
static int btrfs_xattr_acl_default_set(struct inode *inode, const char *name,
const void *value, size_t size, int flags)
{
+ /*
return btrfs_xattr_set(inode, BTRFS_XATTR_INDEX_POSIX_ACL_DEFAULT,
name, value, size, flags);
+ */
+ return -EOPNOTSUPP;
}
struct xattr_handler btrfs_xattr_acl_default_handler = {
OpenPOWER on IntegriCloud