summaryrefslogtreecommitdiffstats
path: root/fs/block_dev.c
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2016-06-09 15:34:02 -0500
committerEric W. Biederman <ebiederm@xmission.com>2016-06-23 15:41:57 -0500
commita2982cc922c3068783eb9a1f77a5626a1ec36a1f (patch)
tree61ccc6ad01f8804d5290ae4565ba8d4238bf648a /fs/block_dev.c
parent3ee690143c3c99f6c0e83f08ff17556890bc6027 (diff)
downloadop-kernel-dev-a2982cc922c3068783eb9a1f77a5626a1ec36a1f.zip
op-kernel-dev-a2982cc922c3068783eb9a1f77a5626a1ec36a1f.tar.gz
vfs: Generalize filesystem nodev handling.
Introduce a function may_open_dev that tests MNT_NODEV and a new superblock flab SB_I_NODEV. Use this new function in all of the places where MNT_NODEV was previously tested. Add the new SB_I_NODEV s_iflag to proc, sysfs, and mqueuefs as those filesystems should never support device nodes, and a simple superblock flags makes that very hard to get wrong. With SB_I_NODEV set if any device nodes somehow manage to show up on on a filesystem those device nodes will be unopenable. Acked-by: Seth Forshee <seth.forshee@canonical.com> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs/block_dev.c')
-rw-r--r--fs/block_dev.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/block_dev.c b/fs/block_dev.c
index 71ccab1..30b8d56 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1857,7 +1857,7 @@ struct block_device *lookup_bdev(const char *pathname)
if (!S_ISBLK(inode->i_mode))
goto fail;
error = -EACCES;
- if (path.mnt->mnt_flags & MNT_NODEV)
+ if (!may_open_dev(&path))
goto fail;
error = -ENOMEM;
bdev = bd_acquire(inode);
OpenPOWER on IntegriCloud