summaryrefslogtreecommitdiffstats
path: root/fs/bio.c
diff options
context:
space:
mode:
authorMuthukumar Ratty <muthur@gmail.com>2014-01-08 09:39:49 -0700
committerJens Axboe <axboe@kernel.dk>2014-01-08 09:39:49 -0700
commit95d4403889acbd98e06d41a255df76452210996a (patch)
tree00d606520db8f3ddc6071653caf05f8a7bc52f56 /fs/bio.c
parent0fec08b4ecfc36fd8a64432343b2964fb86d2675 (diff)
downloadop-kernel-dev-95d4403889acbd98e06d41a255df76452210996a.zip
op-kernel-dev-95d4403889acbd98e06d41a255df76452210996a.tar.gz
block: Warn and free bio if bi_end_io is not set
In bio_endio if bio doesn't have bi_end_io (should be an error case), we set bio to NULL and continue silently without freeing the bio. It would be good to have a WARN and free the bio to avoid memory leak. Signed-off-by: Muthukumar Ratty <muthur@gmail.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'fs/bio.c')
-rw-r--r--fs/bio.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/fs/bio.c b/fs/bio.c
index 75c49a3..9156bd1 100644
--- a/fs/bio.c
+++ b/fs/bio.c
@@ -1770,6 +1770,15 @@ void bio_endio(struct bio *bio, int error)
} else {
if (bio->bi_end_io)
bio->bi_end_io(bio, error);
+ else {
+ char dev_name[BDEVNAME_SIZE];
+
+ WARN(1, "bio_endio: bio for %s without endio\n",
+ bio->bi_bdev ? bdevname(bio->bi_bdev,
+ dev_name) : "(unknown)");
+ bio_put(bio);
+ }
+
bio = NULL;
}
}
OpenPOWER on IntegriCloud