diff options
author | Johannes Berg <johannes.berg@intel.com> | 2011-11-03 00:07:32 +0000 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-11-04 17:47:34 -0400 |
commit | c30bc94758ae2a38a5eb31767c1985c0aae0950b (patch) | |
tree | 2b8e0565fe338a56cecc23ce299590c44e4438b6 /fs/befs | |
parent | 433aee04a447fb2e769c4570f327d9c2a956117b (diff) | |
download | op-kernel-dev-c30bc94758ae2a38a5eb31767c1985c0aae0950b.zip op-kernel-dev-c30bc94758ae2a38a5eb31767c1985c0aae0950b.tar.gz |
netlink: validate NLA_MSECS length
L2TP for example uses NLA_MSECS like this:
policy:
[L2TP_ATTR_RECV_TIMEOUT] = { .type = NLA_MSECS, },
code:
if (info->attrs[L2TP_ATTR_RECV_TIMEOUT])
cfg.reorder_timeout = nla_get_msecs(info->attrs[L2TP_ATTR_RECV_TIMEOUT]);
As nla_get_msecs() is essentially nla_get_u64() plus the
conversion to a HZ-based value, this will not properly
reject attributes from userspace that aren't long enough
and might overrun the message.
Add NLA_MSECS to the attribute minlen array to check the
size properly.
Cc: Thomas Graf <tgraf@suug.ch>
Cc: stable@vger.kernel.org
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'fs/befs')
0 files changed, 0 insertions, 0 deletions