diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2011-01-12 17:00:26 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-01-13 08:03:15 -0800 |
| commit | e0e3d32bb40d28cf57a6a24e1e1d87ef03b913bd (patch) | |
| tree | 7d4f90f2f65544559629dc0b3c2220454571b982 /fs/befs/linuxvfs.c | |
| parent | 25f959d63d39c83fda09d93a052835ed35669b1a (diff) | |
| download | op-kernel-dev-e0e3d32bb40d28cf57a6a24e1e1d87ef03b913bd.zip op-kernel-dev-e0e3d32bb40d28cf57a6a24e1e1d87ef03b913bd.tar.gz | |
befs: don't pass huge structs by value
'struct befs_disk_data_stream' is huge (~144 bytes) and it's being passed
by value in fs/befs/endian.h::cpu_to_fsrun().
It would be better to pass a pointer.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Cc: Will Dyson <will_dyson@pobox.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/befs/linuxvfs.c')
| -rw-r--r-- | fs/befs/linuxvfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index de93581..b1d0c79 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -390,7 +390,7 @@ static struct inode *befs_iget(struct super_block *sb, unsigned long ino) int num_blks; befs_ino->i_data.ds = - fsds_to_cpu(sb, raw_inode->data.datastream); + fsds_to_cpu(sb, &raw_inode->data.datastream); num_blks = befs_count_blocks(sb, &befs_ino->i_data.ds); inode->i_blocks = |
