diff options
| author | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-26 00:57:40 -0500 |
|---|---|---|
| committer | Al Viro <viro@zeniv.linux.org.uk> | 2008-12-31 18:07:43 -0500 |
| commit | 6badd79bd002788aaec27b50a74ab69ef65ab8ee (patch) | |
| tree | 2a47bf53a7fe2316d98cca71f0b7d01d5024a5ea /fs/bad_inode.c | |
| parent | b6b3fdead251d432f32f2cfce2a893ab8a658110 (diff) | |
| download | op-kernel-dev-6badd79bd002788aaec27b50a74ab69ef65ab8ee.zip op-kernel-dev-6badd79bd002788aaec27b50a74ab69ef65ab8ee.tar.gz | |
kill ->dir_notify()
Remove the hopelessly misguided ->dir_notify(). The only instance (cifs)
has been broken by design from the very beginning; the objects it creates
are never destroyed, keep references to struct file they can outlive, nothing
that could possibly evict them exists on close(2) path *and* no locking
whatsoever is done to prevent races with close(), should the previous, er,
deficiencies someday be dealt with.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/bad_inode.c')
| -rw-r--r-- | fs/bad_inode.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/fs/bad_inode.c b/fs/bad_inode.c index 5f1538c..a05287a 100644 --- a/fs/bad_inode.c +++ b/fs/bad_inode.c @@ -132,11 +132,6 @@ static int bad_file_check_flags(int flags) return -EIO; } -static int bad_file_dir_notify(struct file *file, unsigned long arg) -{ - return -EIO; -} - static int bad_file_flock(struct file *filp, int cmd, struct file_lock *fl) { return -EIO; @@ -179,7 +174,6 @@ static const struct file_operations bad_file_ops = .sendpage = bad_file_sendpage, .get_unmapped_area = bad_file_get_unmapped_area, .check_flags = bad_file_check_flags, - .dir_notify = bad_file_dir_notify, .flock = bad_file_flock, .splice_write = bad_file_splice_write, .splice_read = bad_file_splice_read, |
